Extract asynchronous method handler #1756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wplong11
force-pushed
the
3-extract-asynchronous-method-handler
branch
from
3a967cc
to
29fc751
Compare
wplong11
force-pushed
the
3-extract-asynchronous-method-handler
branch
2 times, most recently
from
4845d15
to
72dfc1d
Compare
wplong11
commented
Sep 19, 2022
| import static feign.FeignException.errorExecuting; | ||
| import static feign.Util.checkNotNull; | ||
|
|
||
| final class AsynchronousMethodHandler implements MethodHandler { |
There was a problem hiding this comment.
In this PR, The AsynchronousMethodHandler is just copy and paste of the SynchronousMethodHandler. Then refactored in the PR #1757
wplong11
force-pushed
the
3-extract-asynchronous-method-handler
branch
from
49213b1
to
3c45c01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains #1755 PR commits
If you want to see the final result, see PR #1757