Fixes missing Content-Length header when body is empty #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c00ler
commented
Oct 3, 2022
| <plugin> | ||
| <artifactId>maven-install-plugin</artifactId> | ||
| <version>${maven-install-plugin.version}</version> | ||
| <configuration> | ||
| <createChecksum>true</createChecksum> |
There was a problem hiding this comment.
This property was removed in https://issues.apache.org/jira/browse/MINSTALL-143
c00ler
commented
Oct 3, 2022
| @@ -51,16 +51,6 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Duplicated dependencies
kdavisk6
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultClientwas modified to add the missingContent-Lengthheader toPOSTandPUTrequests.PATCHrequest is not supported by theHttpUrlConnection. SinceContent-Lengthis the restricted header, I set the empty body, and its length is calculated by theHttpUrlConnection.Fixes #1229