Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminates unnecessary overhead #1786

Merged
merged 6 commits into from Oct 11, 2022

Conversation

wplong11
Copy link
Collaborator

@wplong11 wplong11 commented Oct 9, 2022

Goal

  • Enhance readability
  • Enhance performance
    • Eliminates unnecessary overhead caused by CompletableFutre on synchronous operation.

Review Guide

It would be good to review changes in commit units instead of PR.

@wplong11 wplong11 force-pushed the refactor-ResponseHander branch 6 times, most recently from a57a3a9 to 1d6d083 Compare October 10, 2022 07:51
@wplong11 wplong11 marked this pull request as ready for review October 10, 2022 07:52
@wplong11 wplong11 changed the title Refactor response hander Refactor ResponseHandler Oct 10, 2022
@wplong11 wplong11 force-pushed the refactor-ResponseHander branch 2 times, most recently from 9aa5dc0 to 84becff Compare October 10, 2022 08:15
@wplong11 wplong11 marked this pull request as draft October 10, 2022 08:55
@wplong11 wplong11 marked this pull request as ready for review October 10, 2022 09:13
@wplong11
Copy link
Collaborator Author

wplong11 commented Oct 11, 2022

@velo I pushed the modified commit, but Circle CI doesn't seem to be newly triggered

@wplong11 wplong11 changed the title Refactor ResponseHandler Eliminates unnecessary overhead Oct 11, 2022
@velo velo merged commit 2b141a0 into OpenFeign:master Oct 11, 2022
@wplong11 wplong11 deleted the refactor-ResponseHander branch October 11, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants