Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move responsibility for resolving RequestTemplateFactory #1850

Merged
merged 6 commits into from Nov 22, 2022
Merged

Move responsibility for resolving RequestTemplateFactory #1850

merged 6 commits into from Nov 22, 2022

Conversation

wplong11
Copy link
Collaborator

@wplong11 wplong11 commented Nov 19, 2022 •
edited

Changes

  • Extract RequestTemplateFactoryResolver
  • Move responsibility for RequestTemplateFactory creation from ParseHandlersByName to MethodHandler.Factory

Review Guide

  • Review commit by commit. I've broken down the commits to make the diff easier to understand.

@wplong11 wplong11 marked this pull request as ready for review November 19, 2022 10:21
@wplong11 wplong11 force-pushed the Extract-RequestTemplateFactoryResolver branch from 0f4d28d to 0392fe7 Compare November 19, 2022 10:22
@wplong11 wplong11 marked this pull request as draft November 19, 2022 10:24
@wplong11 wplong11 changed the title Extract RequestTemplateFactoryResolver Move responsibility of creating RequestTemplate to MethodHandler.Factory Nov 19, 2022
@wplong11 wplong11 changed the title Move responsibility of creating RequestTemplate to MethodHandler.Factory Move responsibility for RequestTemplate creation to MethodHandler.Factory Nov 19, 2022
@wplong11 wplong11 force-pushed the Extract-RequestTemplateFactoryResolver branch from 0392fe7 to e21d87d Compare November 19, 2022 10:27
@wplong11 wplong11 marked this pull request as ready for review November 19, 2022 10:28
@wplong11 wplong11 force-pushed the Extract-RequestTemplateFactoryResolver branch from e21d87d to 157d4ed Compare November 19, 2022 10:39
@wplong11 wplong11 changed the title Move responsibility for RequestTemplate creation to MethodHandler.Factory Move responsibility for RequestTemplateFactory creation to MethodHandler.Factory Nov 19, 2022
@wplong11 wplong11 changed the title Move responsibility for RequestTemplateFactory creation to MethodHandler.Factory Move responsibility for RequestTemplateFactory creation Nov 19, 2022
@wplong11 wplong11 force-pushed the Extract-RequestTemplateFactoryResolver branch from 157d4ed to e8c17e4 Compare November 20, 2022 08:07
@wplong11 wplong11 changed the title Move responsibility for RequestTemplateFactory creation Move responsibility for resolving RequestTemplateFactory Nov 20, 2022
@velo velo merged commit 273e5dc into OpenFeign:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wplong11 @velo