set root cause as the exception_name in micrometer tags #1883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
reviewed
Dec 16, 2022
| @@ -63,14 +64,14 @@ public Object decode(Response response, Type type) | |||
| } catch (IOException | RuntimeException e) { | |||
| metricRegistry.meter( | |||
| metricName.metricName(template.methodMetadata(), template.feignTarget(), "error_count") | |||
| .tagged("exception_name", e.getClass().getSimpleName()) | |||
| .tagged("exception_name", ExceptionUtils.getRootCause(e).getClass().getSimpleName()) | |||
There was a problem hiding this comment.
I'm thinking a bit more about this.... we are breaking the existing contract with this change.
Can we leave exception_name as was and add root_cause_name for this?
Cheers
There was a problem hiding this comment.
yes, that makes more sense, made the same change in 23cb5ed , can you take a look at it again?
velo
reviewed
Dec 18, 2022
| @@ -65,6 +66,8 @@ protected void recordFailure(RequestTemplate template, FeignException e) { | |||
| httpResponseCode(template), | |||
| "exception_name", | |||
| e.getClass().getSimpleName(), | |||
| "root_cause_name", | |||
| ExceptionUtils.getRootCause(e).getClass().getSimpleName(), | |||
There was a problem hiding this comment.
getCause can return null, in that case would cause NPE
There was a problem hiding this comment.
As long as e is not null, getRootCause won’t return null as we can see here
https://github.com/OpenFeign/feign/pull/1883/files#diff-3bfdf878b3ea38d5268a9d72389c1f54ebabf1d76ad9a308e1eed93d95ed0048R38
velo
approved these changes
Dec 18, 2022
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1882