Ignore Jakarta Suspended and Context, Support BeanParam #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Feb 17, 2023
|
Any ideas on how to keep this 2 modules always in sync? |
@velo I don't think there's a great way to handle it as written without getting too fancy with a shade plugin. Maybe a really generic base class could be extended by jaxrs1, jaxrs2, and jakarta implementations, but this would probably require a new module and the amount of code saved seems minimal to me. It would almost certainly solve the test dependency quirks we were seeing in jdk8 though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small bit of house keeping to bring the Jakarta package in line with the Jaxrs2 package.
Includes the work from jaxrs2 bean param on pr #1935
Fixes #1940