Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2047: Exclude okio from module info #2048

Merged

Conversation

kdavisk6
Copy link
Member

@kdavisk6 kdavisk6 commented May 16, 2023

Closes #2047

This change updates the module info generation for feign-okhttp, excluding okio from the tree since it does not conform to JPMS standards and results in duplicate module entries. See square/okhttp#4184 for information from Square about it.

Additional Changes

  • Ensure Wikipedia with Spring Boot only uses JDK 17
  • Renamed Wikipedia with Spring Boot to be unique

This change updates the module info generation for feign-okhttp, excluding `okio` from the tree since it does not conform to JPMS standards and results in duplicate module entries.  See square/okhttp#4184 for information from Square about it.

Additional Changes
---
* Ensure Wikipedia with Spring Boot only uses JDK 17
* Renamed Wikipedia with Spring Boot to be unique
@kdavisk6 kdavisk6 merged commit fda7329 into OpenFeign:master May 16, 2023
3 checks passed
@kdavisk6 kdavisk6 deleted the gh-2047/disable-okhttp-module-generation branch May 16, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployments to Sonatype are consistently failing
1 participant