Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow QueryMapEncoder accept null value #2086

Merged
merged 1 commit into from Jun 19, 2023
Merged

Allow QueryMapEncoder accept null value #2086

merged 1 commit into from Jun 19, 2023

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jun 16, 2023

For

@GetMapping
public Paged<User> list(int page, int size, @QueryMap User user);

now we can use

Paged<User> paged = userClient.list(1, 10, null);

instead of

Paged<User> paged = userClient.list(1, 10, new User()); // query map will include primitive type default values which is unexpected

@quaff
Allow QueryMapEncoder accept null value
e8ee60e 
For
```java
@GetMapping
public Paged<User> list(int page, int size, @QueryMap User user);
```
now we can use
```java
Paged<User> paged = userClient.list(1, 10, null);
```
instead of
```java
Paged<User> paged = userClient.list(1, 10, new User()); // query map will include primitive type default values which is unexpected
```
@quaff
Copy link
Contributor Author

quaff commented Jun 16, 2023

@velo Please review this one since you close #1463.

@velo velo merged commit c435151 into OpenFeign:master Jun 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quaff @velo