feign-soap-jakarta module like feign-soap, but with feign-jaxb-jakarta instead of feign-jaxb #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
LGTM,
can you also added it to the features?
https://github.com/OpenFeign/feign/blob/master/src/docs/overview-mindmap.iuml#L21
|
@velo Done, I also added JAXB Jakarta to the list, as I realized it was missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using feign clients in conjunction with soap using the newer Jakarta packages instead of old Javax. This feature builds on top of #2014 to add the functionality.
The module is mostly a copy of the feign-soap module with old javax dependencies replaced by jakarta.