Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason for decode404() deprecation #2202

Merged
merged 2 commits into from Oct 20, 2023

Conversation

gromspys
Copy link
Contributor

@gromspys gromspys commented Oct 15, 2023

Issue: #2078

Summary by CodeRabbit

  • Refactor: The decode404() method in our core service has been marked as deprecated. We recommend using the new dismiss404() method for handling 404 errors. This change is part of our ongoing efforts to improve the clarity and consistency of our codebase. Please note that while the decode404() method will continue to function for now, we plan to remove it in a future update. Transitioning to the dismiss404() method will ensure your workflows remain uninterrupted.

@coderabbitai
Copy link

coderabbitai bot commented Oct 15, 2023

Walkthrough

The change in the codebase is a simple yet significant one. It involves the deprecation of the decode404() method in the BaseBuilder.java file, with a suggestion to use the dismiss404() method instead.

Changes

File Summary
.../feign/BaseBuilder.java Deprecated decode404(), use dismiss404() instead

🐇

In the land of code, where logic intertwines,
A method old, its use declines.
Farewell decode404(), your duty ends,
dismiss404(), on you we now depend.

With every change, we grow, we learn,
To better paths, we always turn.
So here's to progress, in bytes and bits,
In the world of code, where a 🐰 sits.


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.
  • Additionally, enter @coderabbitai pause to halt the bot's ongoing reviews as any issue or review comment. To
    resume reviews, enter @coderabbitai resume as any issue or review comment.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between ddb9ff9 and 0712a36.
Files selected for processing (1)
  • core/src/main/java/feign/BaseBuilder.java (1 hunks)
Files skipped from review due to trivial changes (1)
  • core/src/main/java/feign/BaseBuilder.java

@velo velo merged commit dacb086 into OpenFeign:master Oct 20, 2023
3 checks passed
@gromspys gromspys deleted the add-javadoc-for-decode404 branch October 20, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants