Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Client.java #2311

Closed
wants to merge 3 commits into from
Closed

Update Client.java #2311

wants to merge 3 commits into from

Conversation

izdt
Copy link
Contributor

@izdt izdt commented Jan 25, 2024

Fix Isuue #1721 Content-Length may be added twice

@izdt
Update Client.java
61333de 
Fix Isuue OpenFeign#1721 Content-Length may be added twice
@velo velo closed this Jan 31, 2024
@velo velo reopened this Jan 31, 2024
velo
velo requested changes Jan 31, 2024
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look on why CI is broken.

Also, please include unit tests so it never happens again

@izdt
Copy link
Contributor Author

izdt commented Feb 2, 2024

Please take a look on why CI is broken.

Also, please include unit tests so it never happens again

OK, I I will add unit tests later.

@velo
Copy link
Member

velo commented Feb 4, 2024

OK, I I will add unit tests later.

All good, please reopen the PR once done

@velo velo closed this Feb 4, 2024
@izdt izdt mentioned this pull request Feb 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@izdt @velo