-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Dockerfile #348
base: main
Are you sure you want to change the base?
update Dockerfile #348
Conversation
@hurricane1988 Thanks for the contribution. Would you sign your commit like below?: git commit -s --amend
git push -f @wanjunlei @wrongerror @tpiperatgod , please help to review |
@wrongerror could you review my request? |
Could you please describe the purpose of this PR? @hurricane1988 |
@hurricane1988 You need to sign your commit first. And then you'll need to examine why the E2E test failed with your PR? |
OK, I will examine E2E test first. |
# Conflicts: # Dockerfile
@hurricane1988 Your commits look a bit messed up. You may need to rebase or squash your commit:
|
# Build | ||
RUN GOPROXY=${GOPROXY} CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o openfunction main.go | ||
# Build openfunction binary. | ||
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -ldflags '-s -w' -installsuffix cgo -o openfunction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://medium.com/@daviddavid533/cgo-enabled-0-and-installsuffix-cgo-are-no-longer-required-since-go-1-10-127d8c265cb1 according to this, -installsuffix cgo
is no longer needed for go 1.10+
|
remove the main.go in build