X.26 #638
Draft
X.26 #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peter-lawrey please check the deprecations left. There some dependencies thus I was unable to remove them. |
JerryShea
reviewed
Mar 28, 2024
* Review deprecated methods, change build to error on deprecation * Fix compilation on Java 21 * revert * Move ByteBuffers to bytes.internal
#639) * Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail * Remove annotation processor that is more confusing than useful (and often turned off)
* Fix deprecated methods/classes in Core * Add -Xlint:all,-options as default compiler
tgd
approved these changes
May 7, 2024
peter-lawrey
approved these changes
May 13, 2024
JerryShea
reviewed
May 13, 2024
| import java.io.StringWriter; | ||
| import java.util.concurrent.BlockingQueue; | ||
| import java.util.function.BiConsumer; | ||
| import java.util.function.Consumer; | ||
|
|
||
| /** | ||
| * The Mocker class provides utility methods for creating mocked instances of interfaces. |
There was a problem hiding this comment.
should refer to util.Mocker with a comment explaining this here left for backwards compatibility?
JerryShea
approved these changes
May 13, 2024
* Give more time for bg thread in flaky test * Give more time for bg thread in flaky test
* don't use reflection and recursion in IOTools.unmonitor * Using reflection to unmonitor a reference results in errors in Java 17 Fixes #656 * Using reflection to unmonitor a reference results in errors in Java 17 Fixes #656 * Using reflection to unmonitor a reference results in errors in Java 17 Fixes #656 --------- Co-authored-by: Jerry Shea <jerry.shea@chronicle.software>
* Recover from failure on Java21 as mockito isn't supported. * Recover from failure on Java21 as mockito isn't supported.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.