Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X.26 #1554

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

X.26 #1554

wants to merge 33 commits into from

Conversation

yevgenp
Copy link
Contributor

@yevgenp yevgenp commented Apr 1, 2024

No description provided.

@yevgenp yevgenp requested a review from tgd April 1, 2024 11:09
@yevgenp yevgenp changed the base branch from ea to develop April 1, 2024 11:09
@tgd tgd removed their request for review April 26, 2024 08:21
@peter-lawrey peter-lawrey requested a review from tgd May 2, 2024 07:45
tgd
tgd requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@tgd tgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Peter - 2 comments from me - apart from that looks good.

docs/How_it_works.adoc Outdated Show resolved Hide resolved
src/main/java/net/openhft/chronicle/queue/reader/ChronicleHistoryReader.java Show resolved Hide resolved
@tgd tgd requested review from tgd and JerryShea May 7, 2024 16:59
JerryShea
JerryShea requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@JerryShea JerryShea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be rebased on lastest develop

peter-lawrey and others added 14 commits May 20, 2024 11:51
@peter-lawrey
Initial branch of x.26
c16dfc4
@peter-lawrey
Review deprecated methods, change build to error on deprecation (#1551)
04dc06c 
* Review deprecated methods, change build to error on deprecation

* <release>8</release>

* Fix compilation on Java 21

* Don't use OS.getUsrDir() yet

* Use release 8 only for Java 11+

* Turn off implicit annotation processing

* Turn off implicit annotation processing
@peter-lawrey
Add expected exception
0893b14
@peter-lawrey
Add ignored error
5fce79d
@peter-lawrey
Use a common configuration for the compiler-plugin where deprecation … (
377a194 
#1553)

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail

* Use a common configuration for the compiler-plugin where deprecation warnings cause the build to fail
@yevgenp @peter-lawrey
Deprecate RollCycles legacy code.
302835c
@yevgenp @peter-lawrey
Deprecate due x.26.
4122f93
@peter-lawrey
Tidy up compiler setting and some warnings
fabf97f
@peter-lawrey
Reduce the number of raw types
cc3d092
@peter-lawrey
remove deprecated MultiQueue classes
c2fa783
@peter-lawrey
Remove deprecated methods (#1557)
d2c0f8d 
* Remove deprecated methods

* remove deprecated SuppressWarnings
@peter-lawrey
resolve Javadoc issues
8d7a9a3
@peter-lawrey
Added fail on warning lint for Javadoc, and rawtypes fixes for Bytes (#…
ff69f37 
…1558)
@peter-lawrey
import net.openhft.chronicle.wire.Sequence
9cbfb36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
70.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgd tgd tgd approved these changes

@peter-lawrey peter-lawrey Awaiting requested review from peter-lawrey

@JerryShea JerryShea Awaiting requested review from JerryShea

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yevgenp @tgd @peter-lawrey @JerryShea