Support generateTuple being set for an individual WireIn, rather than global all or nothing. #823
+109
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-lawrey
requested review from
tgd,
maxim-ponomarev,
RobAustin and
yevgenp
yevgenp
approved these changes
Jan 31, 2024
RobAustin
approved these changes
Feb 1, 2024
maxim-ponomarev
requested changes
Feb 2, 2024
There was a problem hiding this comment.
WireTypeConverter still doesn't handle unknown classes: see WireTypeConverterWithTuplesTest in 638a7e1
|
Added test (see above) |
|
Let me know, if I'm misusing Tuples and they are not supposed to retain the type information. |
peter-lawrey
force-pushed
the
feature/wire-local-generateTuple
branch
from
c6e0be3
to
2e55df7
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tuples support reading data for a type you don't have locally and then passing it on by writing it.