Leverage Chronicle Tune isolate information when assigning cores #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgd
requested review from
JerryShea,
nicktindall,
peter-lawrey,
rogersimmons and
peter-k-lawrey
and removed request for
JerryShea
README.adoc
Outdated
| @@ -185,6 +185,10 @@ $ for i in "$(ls cpu-*)"; | |||
|
|
|||
| ---- | |||
|
|
|||
| === Chronicle Tune integration | |||
|
|
|||
| https://chronicle.software/tune/[Chronicle Tune] is software that automatically configures your OS for optimal performance. Chronicle Tune can be configured to isolate cores for running low-latency workloads. If Chronicle Tune is actively configured on the target system then Java-Thread-Affinity will automatically load the Tune configuration and record which cores have been isolated. In order to ensure the best performance and the least surprises out of the box Affinity will only consider locking workloads to cores isolated via Chronicle Tune. If Chronicle Tune is installed but no cores are isolated then Affinity will consider all cores as potential lock candidates. | |||
There was a problem hiding this comment.
pls remove the word "automatically" from the first sentence
There was a problem hiding this comment.
Suggest add "also" to " Chronicle Tune can also be configured"....
There was a problem hiding this comment.
Thanks - that's updated
JerryShea
reviewed
Aug 24, 2023
| @@ -400,6 +407,11 @@ public void bind(boolean wholeCore) { | |||
|
|
|||
| final boolean canReserve(boolean specified) { | |||
|
|
|||
| if (isolationSettingsPreventUse()) { | |||
| LOGGER.debug("Cannot reserve CPU {} because it is not isolated by Chronicle Tune", cpuId); | |||
There was a problem hiding this comment.
Thanks - that's updated to cover the two different use cases in which this might get called
nicktindall
approved these changes
Aug 30, 2023
peter-lawrey
approved these changes
Oct 18, 2023
peter-lawrey
requested review from
peter-lawrey
and removed request for
peter-k-lawrey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates Affinity with Chronicle Tune isolate configuration so that Affinity plays nicely with Tune out of the box. With this change, if isolate is installed and cores isolated only cores that are isolated will be eligible for pinning. Please take a look and let me know your thoughts.