prevents "bootstrap class path not set in conjunction with -source 8" #206
Conversation
| @@ -644,6 +644,16 @@ | |||
| <mockito.version>5.5.0</mockito.version> | |||
| </properties> | |||
| </profile> | |||
| <profile> | |||
| <!-- prevents "bootstrap class path not set in conjunction with -source 8" --> | |||
| <id>set-compiler-release</id> | |||
There was a problem hiding this comment.
please see the profile above this ("java11") created by @peter-lawrey
@peter-lawrey I don't understand the purpose of the above profile so need you to review this change. I have made my change next to yours, but please see below.
Why are we not affecting maven-compiler-plugin in a profile in java-parent-pom?
There was a problem hiding this comment.
I suspect the line you are overriding should just be removed instead. Testing this locally.
There was a problem hiding this comment.
If we include JDK11 in this new profile then the existing above should be changed to <jdk>(11,</jdk> at least ?
There was a problem hiding this comment.
@peter-lawrey I tested this change with one of the demos and it worked like a charm. I am keen to get this merged
There was a problem hiding this comment.
This was solved in x.26 by setting -Xlint:-options
There was a problem hiding this comment.
Why have -options when instead we can do this and fix it properly, and we dont have to wait for x26?
Some projects have -Xlint:all and we should be aiming for this for all projects right?
|
#228 solves these problems with |
No description provided.