UART plugin recovers granularity if timing improves #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternewman
requested changes
Feb 28, 2023
There was a problem hiding this comment.
Can you fix the issues cpplint has found and @DaAwesomeP 's excellent work now surface directly within GitHub.
A few more comments, sorry this is only a partial bit of a review.
kripton
reviewed
Feb 28, 2023
|
@kripton & @peternewman thanks for your feedback! I took care of the changes and hopefully the linter will be satisfied now as well. |
peternewman
requested changes
Mar 11, 2023
There was a problem hiding this comment.
Hi @markus983 ,
There are a few outstanding lint issues to begin with please.
|
@peternewman I fixed these lint issues. Hopefully, these were the last. Is there a way to trigger the lint check myself? |
|
Hi, it's been a while, just wanting to make sure that this PR won't be forgotten. Is there anything that is still blocking a merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.