Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Maven version checking (and add Codeql...) #1881

Draft
wants to merge 17 commits into
base: 0.10
Choose a base branch
from

Conversation

peternewman
Copy link
Member

No description provided.

@peternewman peternewman added this to the 0.10.10 milestone Jul 17, 2023
@peternewman peternewman mentioned this pull request Jul 17, 2023
@peternewman
Copy link
Member Author

Also @DaAwesomeP our distcheck isn't currently actually compiling Java.

Take a look at this log:
https://pipelines.actions.githubusercontent.com/serviceHosts/357a19f2-02b8-4511-b538-84bac4c018a4/_apis/pipelines/1/runs/2128/signedlogcontent/4?urlExpires=2023-07-17T06%3A16%3A16.9794407Z&urlSigningMethod=HMACV1&urlSignature=rqYEqDDb9FqFbgSbQ3cTjx2qeyUudZ%2Bs6BFUWlVhgVY%3D

And search for Java API, note how it sets it correctly initially, but not during the second configure.

I think there's a distcheck configure flags if you check our old Travis stuff...

@peternewman
Copy link
Member Author

Also @DaAwesomeP our distcheck isn't currently actually compiling Java.

Search for Java API, note how it sets it correctly initially, but not during the second configure.

I think there's a distcheck configure flags if you check our old Travis stuff...

As confirmed/attempted in #1883 .

@DaAwesomeP
Copy link
Member

DaAwesomeP commented Jul 19, 2023

Also @DaAwesomeP our distcheck isn't currently actually compiling Java.

Take a look at this log: https://pipelines.actions.githubusercontent.com/serviceHosts/357a19f2-02b8-4511-b538-84bac4c018a4/_apis/pipelines/1/runs/2128/signedlogcontent/4?urlExpires=2023-07-17T06%3A16%3A16.9794407Z&urlSigningMethod=HMACV1&urlSignature=rqYEqDDb9FqFbgSbQ3cTjx2qeyUudZ%2Bs6BFUWlVhgVY%3D

And search for Java API, note how it sets it correctly initially, but not during the second configure.

I'm getting a "Uri expired" error. Do you have a link to the build?

I think there's a distcheck configure flags if you check our old Travis stuff...

I'll take a look! We should probably just fix it in this pull. I see #1883.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants