Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixture briteq/beam-fury-1 #1495

Merged
merged 12 commits into from May 13, 2024
Merged

Add fixture briteq/beam-fury-1 #1495

merged 12 commits into from May 13, 2024

Conversation

FloEdelmann
Copy link
Member

  • Add fixture 'briteq/beam-fury-1'

Fixture warnings / errors

  • briteq/beam-fury-1
    • ⚠️ Capability 'Pan angle 0…100%' (0…65535) in channel 'Pan 2' defines an imprecise percentaged angle. Please to try find the value in degrees.
    • ⚠️ Unused channel(s): pan 2, pan 2 fine, tilt 2, tilt 2 fine

Thank you Arthur Moret!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Oct 2, 2020
@FloEdelmann FloEdelmann temporarily deployed to open-fixture-library-pr-1495 October 2, 2020 10:46 Inactive
@FloEdelmann
Copy link
Member Author

See also #2360

@FloEdelmann FloEdelmann mentioned this pull request Mar 19, 2022
Closed
@FloEdelmann FloEdelmann marked this pull request as draft February 16, 2023 16:58
@FloEdelmann FloEdelmann changed the title Add fixture 'briteq/beam-fury-1' Add fixture briteq/beam-fury-1 Feb 16, 2023
kengruven
kengruven reviewed May 12, 2024
View reviewed changes
Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed a bit of cleanup but the fundamentals were sound.

fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
@FloEdelmann @kengruven
Fix dimensions
5888711 
Co-authored-by: Ken Harris <kengruven@gmail.com>
@github-actions github-actions bot deleted a comment from FloEdelmann May 13, 2024
FloEdelmann and others added 4 commits May 13, 2024 16:08
@FloEdelmann @kengruven
Fix Pan/Tilt channels
c493bea 
Co-authored-by: Ken Harris <kengruven@gmail.com>
@FloEdelmann @kengruven
Improve Color Macros channel capabilities
2582b65 
Co-authored-by: Ken Harris <kengruven@gmail.com>
@FloEdelmann @kengruven
Rename modes
d300ed6 
Co-authored-by: Ken Harris <kengruven@gmail.com>
@FloEdelmann @kengruven
Improve Maintenance capabilities
e951736 
Co-authored-by: Ken Harris <kengruven@gmail.com>
FloEdelmann
FloEdelmann commented May 13, 2024
View reviewed changes
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
fixtures/briteq/beam-fury-1.json Outdated Show resolved Hide resolved
@FloEdelmann
Copy link
Member Author

Thanks @kengruven for the review!

@FloEdelmann FloEdelmann marked this pull request as ready for review May 13, 2024 18:07
@github-actions GitHub Actions
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

❌ briteq / beam-fury-1: d-light / attributes-correctness
  • ❌ briteq/beam-fury-1-12ch.xmlError parsing XML: Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/TILT
  • ❌ briteq/beam-fury-1-14ch.xmlError parsing XML: Duplicate parameter name: FOCUS/PAN,Duplicate parameter name: FOCUS/TILT
❌ briteq / beam-fury-1: dmxcontrol3 / channel-numbers
  • ❌ briteq-beam-fury-1-12ch.xmlChannel 12 "Color Macros" is missing capabilities. Used ranges: 0…8, 39…40, 71…72, 103…104, 135…136, 167…168, 199…200, 231…255
  • ❌ briteq-beam-fury-1-14ch.xmlChannel 14 "Color Macros" is missing capabilities. Used ranges: 0…8, 39…40, 71…72, 103…104, 135…136, 167…168, 199…200, 231…255
✔️ briteq / beam-fury-1: dragonframe / json-schema-conformity
  • ✔️ briteq/beam-fury-1.json
  • ✔️ manufacturers.json
✔️ briteq / beam-fury-1: millumin / json-schema-conformity
  • ✔️ briteq/beam-fury-1.json
✔️ briteq / beam-fury-1: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Briteq-BEAM-FURY-1.qxf
✔️ briteq / beam-fury-1: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Briteq-BEAM-FURY-1.qxf

@FloEdelmann FloEdelmann enabled auto-merge (squash) May 13, 2024 18:08
@FloEdelmann FloEdelmann merged commit 2731406 into master May 13, 2024
4 checks passed
@FloEdelmann FloEdelmann deleted the branch2020-10-02T10-46-05 branch May 13, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kengruven kengruven kengruven left review comments

Assignees
No one assigned
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FloEdelmann @kengruven