Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture neewer/tl60-rgb-tube-light-stick #3878

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture neewer/tl60-rgb-tube-light-stick

Fixture warnings / errors

  • neewer/tl60-rgb-tube-light-stick
    • ❌ Category 'Color Changer' invalid since there are no ColorPreset and less than two ColorIntensity capabilities and no Color wheel slots.
    • ❌ Category 'Pixel Bar' invalid since no horizontally aligned matrix is defined.

Thank you blutaz!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Mar 31, 2024
Copy link

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ neewer / tl60-rgb-tube-light-stick: d-light / attributes-correctness
  • ✔️ neewer/tl60-rgb-tube-light-stick-CCT.xml
✔️ neewer / tl60-rgb-tube-light-stick: dmxcontrol3 / channel-numbers
  • ✔️ neewer-tl60-rgb-tube-light-stick-CCT.xml
neewer / tl60-rgb-tube-light-stick: dragonframe / json-schema-conformity
  • ❌ neewer/tl60-rgb-tube-light-stick.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 3-pin (swapped +/-), 3-pin XLR IP65, 5-pin, 5-pin XLR IP65, 3-pin and 5-pin, 3.5mm stereo jack]
  • ✔️ manufacturers.json
neewer / tl60-rgb-tube-light-stick: millumin / json-schema-conformity
  • ❌ neewer/tl60-rgb-tube-light-stick.jsonfixture/physical/DMXconnector "RJ45" must be equal to one of [3-pin, 5-pin, 3-pin (swapped +/-), 3-pin and 5-pin, 3-pin XLR IP65, 3.5mm stereo jack]
✔️ neewer / tl60-rgb-tube-light-stick: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/Neewer-TL60-RGB-Tube-Light-Stick.qxf
neewer / tl60-rgb-tube-light-stick: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/Neewer-TL60-RGB-Tube-Light-Stick.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, there's no manual available online for this fixture. The "Chamsys Fixture Finder" (the "other" link) has a 4-channel mapping, and this file matches that.

There's almost certainly more sophisticated modes, but I don't see an easy way to figure out what they are.

"https://it.neewer.com/collections/rgb-lights/products/neewer-tl60-rgb-tube-rgbww-light-stick-66602907"
],
"video": [
"https://www.youtube.com/watch?v=GyklHZz0MIU&si=u_uiZhWCT8nd2vLt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.youtube.com/watch?v=GyklHZz0MIU&si=u_uiZhWCT8nd2vLt"
"https://www.youtube.com/watch?v=GyklHZz0MIU"

},
"links": {
"manual": [
"https://support.neewer.com/firmware_instruction"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product page says to go here for manuals, but I see no manual here.

"type": "Intensity"
}
},
"Green/Magenta": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't ideal, but all the other fixtures in OFL just use a pile of Generic capabilities for green/magenta point, so I guess it's the best we can do right now.

@blutaz00
Copy link

blutaz00 commented Apr 3, 2024

Hi everybody, I'd like to thanks all the people here for your amazing work, thanks so much for your efforts in keep this repository up and running with all the updates. This is my fist fixture and I didn't really know very well how to do it but I tried. The fixture I published is one of a more complex system of fixtures of the same light, I was able just to publish the first mode looking for help in doing the rest of the job. Today I found the light manual and the dmx table, you can find them here:
manual: https://drive.google.com/file/d/1jN9up84Qke7Pe6J5X3XqUxJEizWnO_YW/view?usp=sharing
dmx tale: https://drive.google.com/file/d/1Cq2BAuAPLEWzJ_KTSDHWNl14m-VKPJmH/view?usp=sharing
@kengruven
ciao

@blutaz00
Copy link

blutaz00 commented Apr 9, 2024

Hi guys, how can I help to fix this fixture in order to publish it? Thanks.

@kengruven
@dimitre

@kengruven
Copy link
Contributor

The DMX table scan is a great help. To clarify, is the first assigned DMX channel a switch to select the fixture’s personality? I’ve never actually seen that before — it’s always an out-of-band setting.

And for OFL: how do you map a fixture with various personalities (from 4 to 56 channels) which depend on the first channel? My impression was that switched channels only work if all options have the same number of channels.

An idea I thought of: map each personality separately, as usual, and make the first channel in each mode a “constant” channel with a representative value. I don’t know that that’s what constant channels were meant for, but I can’t imagine what else they’d be used for!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants