Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture eurolite/led-ip-par #3885

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Add fixture eurolite/led-ip-par

Thank you Alex!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ eurolite / led-ip-par: d-light / attributes-correctness
  • ✔️ eurolite/led-ip-par-8.xml
✔️ eurolite / led-ip-par: dmxcontrol3 / channel-numbers
  • ✔️ eurolite-led-ip-par-8.xml
✔️ eurolite / led-ip-par: dragonframe / json-schema-conformity
  • ✔️ eurolite/led-ip-par.json
  • ✔️ manufacturers.json
✔️ eurolite / led-ip-par: millumin / json-schema-conformity
  • ✔️ eurolite/led-ip-par.json
eurolite / led-ip-par: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Eurolite-LED-IP-PAR.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:8: No physical data found 1 definitions processed. 1 errors detected
✔️ eurolite / led-ip-par: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Eurolite-LED-IP-PAR.qxf

},
"modes": [
{
"name": "8",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has 3/5/6/12-ch modes, too.

Color presets look very similar (but not identical to) eurolite/led-tl-3-rgb-uv and eurolite/led-tl-4-qcl -- maybe copy one of those as a starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants