Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture betopper/led-mini-flat-par-light-54x1-5w-rgb #3900

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture betopper/led-mini-flat-par-light-54x1-5w-rgb

Fixture warnings / errors

  • betopper/led-mini-flat-par-light-54x1-5w-rgb
    • ⚠️ Mode '7 channel' should have shortName '7ch' instead of '7'.

Thank you anonymous!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 7, 2024
Copy link

github-actions bot commented Apr 7, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ betopper / led-mini-flat-par-light-54x1-5w-rgb: d-light / attributes-correctness
  • ✔️ betopper/led-mini-flat-par-light-54x1-5w-rgb-7.xml
betopper / led-mini-flat-par-light-54x1-5w-rgb: dmxcontrol3 / channel-numbers
  • ❌ betopper-led-mini-flat-par-light-54x1-5w-rgb-7.xmlChannel 6 "Choose" is missing capabilities. Used ranges: 0…50, 101…255
✔️ betopper / led-mini-flat-par-light-54x1-5w-rgb: dragonframe / json-schema-conformity
  • ✔️ betopper/led-mini-flat-par-light-54x1-5w-rgb.json
  • ✔️ manufacturers.json
✔️ betopper / led-mini-flat-par-light-54x1-5w-rgb: millumin / json-schema-conformity
  • ✔️ betopper/led-mini-flat-par-light-54x1-5w-rgb.json
✔️ betopper / led-mini-flat-par-light-54x1-5w-rgb: qlcplus_4.12.2 / fixture-tool-validation
  • ✔️ fixtures/betopper-LED-Mini-Flat-Par-Light-54x1.5W-RGB.qxf
✔️ betopper / led-mini-flat-par-light-54x1-5w-rgb: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/betopper-LED-Mini-Flat-Par-Light-54x1.5W-RGB.qxf

@kengruven
Copy link
Contributor

This fixture (LPC008) has exactly the same DMX mapping as betopper/par-54-x-3w-rgb (LPC007) in #3836. Should we combine them into one file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants