Add fixture american-dj/starball-led-3w
#3904
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ american-dj / starball-led-3w: d-light / attributes-correctness
✔️ american-dj / starball-led-3w: dmxcontrol3 / channel-numbers
✔️ american-dj / starball-led-3w: dragonframe / json-schema-conformity
✔️ american-dj / starball-led-3w: millumin / json-schema-conformity
✔️ american-dj / starball-led-3w: qlcplus_4.12.2 / fixture-tool-validation
✔️ american-dj / starball-led-3w: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
Apr 13, 2024
| "https://www.adj.eu/starball-led-dmx" | ||
| ], | ||
| "video": [ | ||
| "https://www.youtube.com/watch?v=--zDT5OUrks&si=EEX6or_Ts9Fbv-TC" |
There was a problem hiding this comment.
Suggested change
| "https://www.youtube.com/watch?v=--zDT5OUrks&si=EEX6or_Ts9Fbv-TC" | |
| "https://www.youtube.com/watch?v=--zDT5OUrks" |
Comment on lines
+34
to
+63
| "capabilities": [ | ||
| { | ||
| "dmxRange": [0, 7], | ||
| "type": "Intensity", | ||
| "brightnessStart": "off", | ||
| "brightnessEnd": "off", | ||
| "comment": "Closed" | ||
| }, | ||
| { | ||
| "dmxRange": [8, 199], | ||
| "type": "Intensity", | ||
| "brightnessStart": "dark", | ||
| "brightnessEnd": "bright", | ||
| "comment": "Dimmer" | ||
| }, | ||
| { | ||
| "dmxRange": [200, 247], | ||
| "type": "StrobeSpeed", | ||
| "speedStart": "1%", | ||
| "speedEnd": "100%", | ||
| "comment": "Strobing Slow-Fast" | ||
| }, | ||
| { | ||
| "dmxRange": [248, 255], | ||
| "type": "Intensity", | ||
| "brightnessStart": "bright", | ||
| "brightnessEnd": "bright", | ||
| "comment": "Open" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Suggested change
| "capabilities": [ | |
| { | |
| "dmxRange": [0, 7], | |
| "type": "Intensity", | |
| "brightnessStart": "off", | |
| "brightnessEnd": "off", | |
| "comment": "Closed" | |
| }, | |
| { | |
| "dmxRange": [8, 199], | |
| "type": "Intensity", | |
| "brightnessStart": "dark", | |
| "brightnessEnd": "bright", | |
| "comment": "Dimmer" | |
| }, | |
| { | |
| "dmxRange": [200, 247], | |
| "type": "StrobeSpeed", | |
| "speedStart": "1%", | |
| "speedEnd": "100%", | |
| "comment": "Strobing Slow-Fast" | |
| }, | |
| { | |
| "dmxRange": [248, 255], | |
| "type": "Intensity", | |
| "brightnessStart": "bright", | |
| "brightnessEnd": "bright", | |
| "comment": "Open" | |
| } | |
| ] | |
| "capabilities": [ | |
| { | |
| "dmxRange": [0, 7], | |
| "type": "ShutterStrobe", | |
| "shutterEffect": "Closed" | |
| }, | |
| { | |
| "dmxRange": [8, 199], | |
| "type": "Intensity", | |
| "brightnessStart": "off", | |
| "brightnessEnd": "bright" | |
| }, | |
| { | |
| "dmxRange": [200, 247], | |
| "type": "ShutterStrobe", | |
| "shutterEffect": "Strobe", | |
| "speedStart": "slow", | |
| "speedEnd": "fast" | |
| }, | |
| { | |
| "dmxRange": [248, 255], | |
| "type": "ShutterStrobe", | |
| "shutterEffect": "Open" | |
| } | |
| ] |
Comment on lines
+66
to
+99
| "capabilities": [ | ||
| { | ||
| "dmxRange": [0, 9], | ||
| "type": "Rotation", | ||
| "speed": "0rpm", | ||
| "comment": "No Rotation" | ||
| }, | ||
| { | ||
| "dmxRange": [10, 120], | ||
| "type": "Rotation", | ||
| "speedStart": "fast CW", | ||
| "speedEnd": "slow CW", | ||
| "comment": "CW Fast-Slow" | ||
| }, | ||
| { | ||
| "dmxRange": [121, 134], | ||
| "type": "Rotation", | ||
| "speed": "0rpm", | ||
| "comment": "No Rotation" | ||
| }, | ||
| { | ||
| "dmxRange": [135, 245], | ||
| "type": "Rotation", | ||
| "speedStart": "slow CCW", | ||
| "speedEnd": "fast CCW", | ||
| "comment": "CCW" | ||
| }, | ||
| { | ||
| "dmxRange": [246, 255], | ||
| "type": "Rotation", | ||
| "speed": "0rpm", | ||
| "comment": "No Rotation" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Suggested change
| "capabilities": [ | |
| { | |
| "dmxRange": [0, 9], | |
| "type": "Rotation", | |
| "speed": "0rpm", | |
| "comment": "No Rotation" | |
| }, | |
| { | |
| "dmxRange": [10, 120], | |
| "type": "Rotation", | |
| "speedStart": "fast CW", | |
| "speedEnd": "slow CW", | |
| "comment": "CW Fast-Slow" | |
| }, | |
| { | |
| "dmxRange": [121, 134], | |
| "type": "Rotation", | |
| "speed": "0rpm", | |
| "comment": "No Rotation" | |
| }, | |
| { | |
| "dmxRange": [135, 245], | |
| "type": "Rotation", | |
| "speedStart": "slow CCW", | |
| "speedEnd": "fast CCW", | |
| "comment": "CCW" | |
| }, | |
| { | |
| "dmxRange": [246, 255], | |
| "type": "Rotation", | |
| "speed": "0rpm", | |
| "comment": "No Rotation" | |
| } | |
| ] | |
| "capabilities": [ | |
| { | |
| "dmxRange": [0, 9], | |
| "type": "Rotation", | |
| "speed": "stop" | |
| }, | |
| { | |
| "dmxRange": [10, 120], | |
| "type": "Rotation", | |
| "speedStart": "fast CW", | |
| "speedEnd": "slow CW" | |
| }, | |
| { | |
| "dmxRange": [121, 134], | |
| "type": "Rotation", | |
| "speed": "stop" | |
| }, | |
| { | |
| "dmxRange": [135, 245], | |
| "type": "Rotation", | |
| "speedStart": "slow CCW", | |
| "speedEnd": "fast CCW" | |
| }, | |
| { | |
| "dmxRange": [246, 255], | |
| "type": "Rotation", | |
| "speed": "stop" | |
| } | |
| ] |
| }, | ||
| "modes": [ | ||
| { | ||
| "name": "2-Ch", |
There was a problem hiding this comment.
Suggested change
| "name": "2-Ch", | |
| "name": "2-channel", | |
| "shortName": "2ch", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
american-dj/starball-led-3wFixture warnings / errors
Thank you Gamby!