Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture stage4/g-spot-150-bsw #3905

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FloEdelmann
Copy link
Member

  • Update manufacturers.json
  • Add fixture stage4/g-spot-150-bsw

Fixture warnings / errors

  • stage4/g-spot-150-bsw
    • ❌ File does not match schema: fixture/wheels/Animation wheel/slots must NOT have fewer than 2 items
    • ❌ File does not match schema: fixture/wheels/Animation wheel/slots/0 (type: Unknown) value of tag "type" must be in oneOf
    • ❌ File does not match schema: fixture/modes/1/channels must NOT have fewer than 1 items
    • ❌ File does not match schema: fixture/modes/2/channels must NOT have fewer than 1 items
    • ⚠️ Please check if manufacturer is correct and add manufacturer URL.

Thank you Avolites and alexander!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

stage4 / g-spot-150-bsw: d-light / attributes-correctness
  • Unable to export fixture: Given DMX value was outside the given resolution
stage4 / g-spot-150-bsw: dmxcontrol3 / channel-numbers
  • Unable to export fixture: Cannot read properties of null (reading 'every')
stage4 / g-spot-150-bsw: dragonframe / json-schema-conformity
  • ❌ stage4/g-spot-150-bsw.jsonfixture/wheels/Animation wheel/slots must NOT have fewer than 2 items
  • ✔️ manufacturers.json
stage4 / g-spot-150-bsw: millumin / json-schema-conformity
  • Unable to export fixture: Given DMX value was outside the given resolution
stage4 / g-spot-150-bsw: qlcplus_4.12.2 / fixture-tool-validation
  • Unable to export fixture: Cannot read properties of null (reading 'every')
stage4 / g-spot-150-bsw: qlcplus_4.12.2 / xsd-schema-conformity
  • Unable to export fixture: Cannot read properties of null (reading 'every')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant