Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture generic/color-temperature-fader #3946

Merged
merged 7 commits into from May 13, 2024

Conversation

FloEdelmann
Copy link
Member

  • Add fixture generic/color-temperature-fader

Thank you Ken!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels May 4, 2024
Copy link

github-actions bot commented May 4, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ generic / color-temperature-fader: d-light / attributes-correctness
  • ✔️ generic/color-temperature-fader-8bit.xml
  • ✔️ generic/color-temperature-fader-16bit.xml
✔️ generic / color-temperature-fader: dmxcontrol3 / channel-numbers
  • ✔️ generic-color-temperature-fader-8bit.xml
  • ✔️ generic-color-temperature-fader-16bit.xml
✔️ generic / color-temperature-fader: dragonframe / json-schema-conformity
  • ✔️ generic/color-temperature-fader.json
  • ✔️ manufacturers.json
✔️ generic / color-temperature-fader: millumin / json-schema-conformity
  • ✔️ generic/color-temperature-fader.json
generic / color-temperature-fader: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/Generic-Color-Temperature-Fader.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf:8 bit: No physical data found ./manufacturer/fixture.qxf:16 bit: No physical data found 1 definitions processed. 2 errors detected
✔️ generic / color-temperature-fader: qlcplus_4.12.2 / xsd-schema-conformity
  • ✔️ fixtures/Generic-Color-Temperature-Fader.qxf

@kengruven
Copy link
Contributor

I've seen a number of fixtures like this and I think it's worthwhile to have a usable generic mapping for them all.

See, for example, the pull requests for the "Godox" fixtures. They seem to all support this mapping, but also some much more complex modes, so they aren't going to get done any time soon.

@kengruven
Copy link
Contributor

@FloEdelmann: here's the generic version of #3942.

By the way: Sorry for all the fixture reviews. I'm recovering from an injury and have too much time this month!

@FloEdelmann
Copy link
Member Author

here's the generic version of #3942.

Ah, thanks for the link!

By the way: Sorry for all the fixture reviews. I'm recovering from an injury and have too much time this month!

Oh, no worries! Reviewed open PRs are much better than unreviewed open PRs 😅
I hope you're doing well! At least with OFL you have something to distract yourself 🙂

@FloEdelmann FloEdelmann marked this pull request as ready for review May 13, 2024 18:14
@FloEdelmann
Copy link
Member Author

Thanks @kengruven!

@FloEdelmann FloEdelmann enabled auto-merge (squash) May 13, 2024 18:15
@FloEdelmann FloEdelmann merged commit 34cec70 into master May 13, 2024
4 checks passed
@FloEdelmann FloEdelmann deleted the branch2024-05-04T16-27-43 branch May 13, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants