Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixture beamz/fuze-2812 #3955

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

FloEdelmann
Copy link
Member

  • Add fixture beamz/fuze-2812

Fixture warnings / errors

  • beamz/fuze-2812
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?bpm$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?bpm$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedEnd "fast CW" must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Color Macros 2/capabilities/13/speedEnd "fast CW" must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?bpm$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedStart "slow CW" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedStart "slow CW" must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedStart "slow CW" must match exactly one schema in oneOf
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?Hz$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?bpm$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedEnd "fast CW" must match pattern "^-?[0-9]+(.[0-9]+)?%$"
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedEnd "fast CW" must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    • ❌ File does not match schema: fixture/availableChannels/Dynamic Rotate/capabilities/1/speedEnd "fast CW" must match exactly one schema in oneOf

Thank you Caleb!

@FloEdelmann FloEdelmann added new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website. labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Export files validity

(Output of test script tests/github/exports-valid.js.)

Test the exported files of selected fixtures against the plugins' export tests.
You can run a plugin's export tests by executing:
$ node cli/run-export-test.js -p <plugin name> <fixtures>

✔️ beamz / fuze-2812: d-light / attributes-correctness
  • ✔️ beamz/fuze-2812-21 CH.xml
beamz / fuze-2812: dmxcontrol3 / channel-numbers
  • ❌ beamz-fuze-2812-21-CH.xmlCapability 64…95 in channel 2 overlaps with other capabilities.
    Channel 2 "Shutter" is missing capabilities. Used ranges: 32…255
beamz / fuze-2812: dragonframe / json-schema-conformity
  • ❌ beamz/fuze-2812.jsonfixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(\.[0-9]+)?Hz$"
    fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(\.[0-9]+)?bpm$"
    fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match pattern "^-?[0-9]+(\.[0-9]+)?%$"
    fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must be equal to one of [fast, slow, stop, slow reverse, fast reverse]
    fixture/availableChannels/Color Macros 2/capabilities/13/speedStart "slow CW" must match exactly one schema in oneOf
    fixture/availableChannels/Color Macros 2/capabilities/13 (type: Effect) must match "then" schema
  • ✔️ manufacturers.json
✔️ beamz / fuze-2812: millumin / json-schema-conformity
  • ✔️ beamz/fuze-2812.json
beamz / fuze-2812: qlcplus_4.12.2 / fixture-tool-validation
  • ❌ fixtures/BeamZ-FUZE-2812.qxfNamespace(map=False, convert=None, validate=['.']) Starting validation ./manufacturer/fixture.qxf: Invalid physical dimensions detected 1 definitions processed. 1 errors detected
beamz / fuze-2812: qlcplus_4.12.2 / xsd-schema-conformity
  • ❌ fixtures/BeamZ-FUZE-2812.qxfElement '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Weight': [facet 'minExclusive'] The value '0' must be greater than '0'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Width': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Height': '0' is not a valid value of the atomic type 'xs:positiveInteger'.
    Element '{http://www.qlcplus.org/FixtureDefinition}Dimensions', attribute 'Depth': '0' is not a valid value of the atomic type 'xs:positiveInteger'.

Copy link
Contributor

@kengruven kengruven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The basics of this look pretty good. I just did a bunch of minor cleanup.

There's still a 45-ch mode to do (which adds RGBWAU control in each of 4 regions = 6x4 more channels), but I'm not sure how to do those yet.

"https://www.beamzlighting.com/wp-content/uploads/2024/03/150.350-Fuze2812-Moving-Head_manual_V1.2.pdf"
],
"productPage": [
"https://beamzlighting.com/product/fuze2812-wash-moving-head-with-zoom/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://beamzlighting.com/product/fuze2812-wash-moving-head-with-zoom/"
"https://www.beamzlighting.com/product/fuze2812-led-wash-moving-head-with-zoom/"

{
"$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json",
"name": "FUZE 2812",
"categories": ["Moving Head"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"categories": ["Moving Head"],
"categories": ["Moving Head", "Color Changer"],

},
"links": {
"manual": [
"https://www.beamzlighting.com/wp-content/uploads/2024/03/150.350-Fuze2812-Moving-Head_manual_V1.2.pdf"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.beamzlighting.com/wp-content/uploads/2024/03/150.350-Fuze2812-Moving-Head_manual_V1.2.pdf"
"https://www.beamzlighting.com/wp-content/uploads/2024/05/150.350-Fuze2812-Moving-Head_manual_V1.2.pdf"

"https://beamzlighting.com/product/fuze2812-wash-moving-head-with-zoom/"
],
"video": [
"https://www.youtube.com/watch?v=ns21Var4-Ao&ab_channel=TroniosBV"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"https://www.youtube.com/watch?v=ns21Var4-Ao&ab_channel=TroniosBV"
"https://www.youtube.com/watch?v=ns21Var4-Ao"

Comment on lines +103 to +120
"Tilt 2": {
"name": "Tilt",
"fineChannelAliases": ["Tilt 2 fine"],
"capability": {
"type": "Tilt",
"angleStart": "0deg",
"angleEnd": "270deg"
}
},
"Tilt 3": {
"name": "Tilt",
"fineChannelAliases": ["Tilt 3 fine"],
"capability": {
"type": "Tilt",
"angleStart": "0deg",
"angleEnd": "270deg"
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Tilt 2": {
"name": "Tilt",
"fineChannelAliases": ["Tilt 2 fine"],
"capability": {
"type": "Tilt",
"angleStart": "0deg",
"angleEnd": "270deg"
}
},
"Tilt 3": {
"name": "Tilt",
"fineChannelAliases": ["Tilt 3 fine"],
"capability": {
"type": "Tilt",
"angleStart": "0deg",
"angleEnd": "270deg"
}
},

Comment on lines +496 to +498
"effectName": "Dynamic rotate 1",
"speedStart": "slow CW",
"speedEnd": "fast CW"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"effectName": "Dynamic rotate 1",
"speedStart": "slow CW",
"speedEnd": "fast CW"
"effectName": "Dynamic rotate 1"

Comment on lines +587 to +588
"type": "Effect",
"effectName": "Motor reset"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "Effect",
"effectName": "Motor reset"
"type": "Maintenance",
"comment": "Motor reset"

Comment on lines +596 to +597
"type": "Effect",
"effectName": "Zoom motor reset"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "Effect",
"effectName": "Zoom motor reset"
"type": "Maintenance",
"comment": "Zoom motor reset"

{
"dmxRange": [240, 255],
"type": "Effect",
"effectName": "Internal Sound program 1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"effectName": "Internal Sound program 1"
"effectName": "Internal Sound program 1",
"soundControlled": true

Comment on lines +462 to +463
"speedStart": "slow CW",
"speedEnd": "fast CW",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"speedStart": "slow CW",
"speedEnd": "fast CW",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-fixture Request or implementation to add a new fixture definition. via-editor Opened via the editor on the open-fixture-library.org website.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants