Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Travis JS related tests #300

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Member

No description provided.

Copy link
Contributor

@daveol daveol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems fine, some minor nitpicks

Comment on lines 10 to 12
directories:
- $HOME/.npm
- $HOME/.cache/pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this if we use Travis's built-in definitions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.

Comment on lines 3 to +4
before_cache:
- rm -f $HOME/.cache/pip/log/debug.log # erase log
- rm -f $HOME/.cache/pip/log/debug.log # erase log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed when using Travis's built-in definitions for the cache?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not sure. At one point caching was only available in the pro one unless you configured it yourself! I don't know if it dealt with such subtleties too, so I'm tempted to leave it given it doesn't really do any harm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants