add checkpoint apis #319
Open
add checkpoint apis #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #319 +/- ##
==========================================
+ Coverage 30.83% 31.76% +0.92%
==========================================
Files 54 56 +2
Lines 1456 1571 +115
Branches 229 249 +20
==========================================
+ Hits 449 499 +50
- Misses 964 1025 +61
- Partials 43 47 +4
Continue to review full report at Codecov.
|
mccorby
requested changes
Apr 13, 2021
| @@ -125,25 +132,48 @@ class SyftJob internal constructor( | |||
| plans: ConcurrentHashMap<String, Plan>, | |||
| clientConfig: ClientConfig, | |||
| dataLoader: DataLoader, | |||
| trainingParameters: TrainingParameters | |||
| trainingParameters: TrainingParameters, | |||
| checkPointSerializer: CheckPointSerializer? = null | |||
There was a problem hiding this comment.
Can we pass this in the constructor?
Also, why clientConfig had to be passed here and not in the constructor? Can a job execute different plans with different client configurations?
There was a problem hiding this comment.
because clientConfig will only be available when the job is on ReadyStatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist