Layer normalization

[jsenellart]

No description provided.

[codecov-io]

Codecov Report

Merging #255 into master will increase coverage by 0.21%.
The diff coverage is 84.52%.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   69.71%   69.92%   +0.21%     
==========================================
  Files          64       65       +1     
  Lines        5303     5360      +57     
==========================================
+ Hits         3697     3748      +51     
- Misses       1606     1612       +6

Impacted Files	Coverage Δ
onmt/Factory.lua	27.97% <0%> (-1.23%)	⬇️
onmt/modules/Decoder.lua	91.51% <100%> (ø)	⬆️
onmt/modules/PDBiEncoder.lua	91.66% <100%> (+0.91%)	⬆️
onmt/utils/MemoryOptimizer.lua	86.2% <100%> (+0.11%)	⬆️
onmt/modules/DBiEncoder.lua	98.86% <100%> (+1.16%)	⬆️
onmt/modules/init.lua	100% <100%> (ø)	⬆️
onmt/modules/Encoder.lua	97.97% <100%> (+0.1%)	⬆️
onmt/modules/LSTM.lua	98.41% <100%> (+0.19%)	⬆️
onmt/modules/LayerNormalization.lua	100% <100%> (ø)
onmt/modules/GRU.lua	93.54% <85.71%> (-4.53%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e794053...774132f. Read the comment docs.

[vince62s]

is there a reason why this PR is not merged ? no improvement ?

[StevenLOL]

? Any update ?

[guillaumekln]

As far as I know, we did not see any gains.

[jsenellart]

yes - there is no obvious gain for NMT. I will still prep the request for merge so that it can be tested for other tasks.