Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

memory graph #303

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

memory graph #303

wants to merge 20 commits into from

Conversation

jsenellart
Copy link
Contributor

@jsenellart jsenellart commented Jun 1, 2017

better memory optimization using the computation graph, implement first vertical memory sharing

@codecov-io
Copy link

codecov-io commented Jun 1, 2017

Codecov Report

Merging #303 into master will increase coverage by 0.34%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #303      +/-   ##
=========================================
+ Coverage   77.15%   77.5%   +0.34%     
=========================================
  Files          66      67       +1     
  Lines        5270    5356      +86     
=========================================
+ Hits         4066    4151      +85     
- Misses       1204    1205       +1
Impacted Files Coverage Δ
onmt/utils/ExtendedCmdLine.lua 70.73% <100%> (+1.98%) ⬆️
onmt/utils/init.lua 100% <100%> (ø) ⬆️
onmt/utils/MemoryGraph.lua 100% <100%> (ø)
onmt/Model.lua 79.31% <60%> (-4.03%) ⬇️
onmt/utils/Features.lua 98.38% <0%> (+1.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 118e1e1...357494e. Read the comment docs.

@jsenellart
Copy link
Contributor Author

temporary withdrawing to extend to non-nngraph models

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants