This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
[WIP] Label smoothing #528
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jsenellart
commented
Mar 24, 2018
jsenellart
commented
- implement label smoothing as defined in Szegedy, 2015 - uniform distribution
added 9 commits
March 24, 2018 18:31
Codecov Report
@@ Coverage Diff @@
## master #528 +/- ##
==========================================
- Coverage 64.25% 64.02% -0.23%
==========================================
Files 77 78 +1
Lines 7237 7278 +41
==========================================
+ Hits 4650 4660 +10
- Misses 2587 2618 +31
Continue to review full report at Codecov.
|
jungikim
reviewed
Mar 27, 2018
onmt/Seq2Seq.lua
Outdated
| @@ -176,12 +180,12 @@ end | |||
|
|
|||
| function Seq2Seq:setGeneratorVocab(t) | |||
| self.models.decoder.generator:setGeneratorVocab(t) | |||
| self.criterion.mainCriterion.weights:resize(t:size(1)) | |||
| self.criterion:updateVocav(t) | |||
There was a problem hiding this comment.
Typo: updateVocav -> updateVocab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.