Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let heavy snow and blizzards make guests buy and use umbrellas #21986

Merged
merged 3 commits into from May 14, 2024

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented May 7, 2024

A few years ago, we introduced snowy weather effects to OpenRCT2. However, these never had any effect on guests' behaviour. This PR changes that, such that heavy snow and blizzard weather makes guests buy and use umbrellas, just like rain.

I've chosen to let normal 'snow' weather not have the same effect, as its effect appears much gentler. I think it would be more realistic for umbrellas to stay hidden in such weather.

It might be nice for snowy weather to have an effect on hat sales, but that's up for debate -- and something for another PR, I think.

Implements #20240

@cheweytoo
Copy link

Ohh, I do like the hat idea!

@AaronVanGeffen AaronVanGeffen added the changelog This issue/PR deserves a changelog entry. label May 10, 2024
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise seems alright

@AaronVanGeffen AaronVanGeffen added the squash merge A PR that should be squashed on merge. label May 14, 2024
@AaronVanGeffen AaronVanGeffen merged commit 6c66bff into OpenRCT2:develop May 14, 2024
22 checks passed
@AaronVanGeffen AaronVanGeffen deleted the snow-umbrellas branch May 14, 2024 17:18
@tupaschoal tupaschoal added this to the v0.4.12 milestone May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog This issue/PR deserves a changelog entry. squash merge A PR that should be squashed on merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants