add flag to json image import #21999
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacek531
force-pushed
the
add-flag-too-json
branch
from
c2e9b84
to
8b5712d
Compare
What are they? I’d prefer doing this right - once we expose something to JSON, we can’t really remove it, so I’d like to get this right first time. |
spacek531
force-pushed
the
add-flag-too-json
branch
from
8b5712d
to
3bcfd17
Compare
It turns out I misspoke. I saw there were other flags in the G1_FLAG enum but the only ones that are useful and aren't exposed to JSON are this and zoom sprite, which is broken. |
spacek531
force-pushed
the
add-flag-too-json
branch
from
3bcfd17
to
e12bf2a
Compare
|
I don't know why tests are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several flags that could be exposed to json for convenience of custom object creators. This is one of them.