Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding --sequential-init to avoid hypothetical concurrent initialization collisions. #47

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

vctqs1
Copy link
Contributor

@vctqs1 vctqs1 commented Dec 18, 2023

What:

sequentialInit boolean --sequential-init Avoid hypothetical concurrent initialization collisions.
sequentialPrepare boolean --sequential-prepare Avoid hypothetical concurrent preparation collisions. True by default

Why:


Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (010d7e3) 100.00% compared to head (247469a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #47   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          130       130           
  Branches        49        49           
=========================================
  Hits           130       130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let’s give it a shot

@mpeyper mpeyper merged commit f74fde2 into OpenSourceRaidGuild:main Dec 18, 2023
4 checks passed
@vctqs1
Copy link
Contributor Author

vctqs1 commented Dec 18, 2023

@vctqs1
Copy link
Contributor Author

vctqs1 commented Dec 18, 2023

I've no clue, what should we do now, do you have any suggestion? @mpeyper

@mpeyper
Copy link
Member

mpeyper commented Dec 18, 2023

Unfortunately not. Last time I did any work on this it just worked so I'm a bit confused as to how to fix this.

I'll raise an issue with multi-semantic-release asking for some help, but not sure what kind of turn around time that might have.

mpeyper added a commit that referenced this pull request Dec 18, 2023
mpeyper added a commit that referenced this pull request Dec 18, 2023
@vctqs1
Copy link
Contributor Author

vctqs1 commented Dec 18, 2023

okay thank you

@mpeyper
Copy link
Member

mpeyper commented Dec 18, 2023

FYI @vctqs1 - #48, #49

Copy link

🎉 This PR is included in version 1.1.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@mpeyper
Copy link
Member

mpeyper commented Dec 18, 2023

Looks like #49 fixed it @vctqs1

@vctqs1
Copy link
Contributor Author

vctqs1 commented Dec 18, 2023

thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants