fix: Cannot find module '.\dir\foo.js' under windows #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpeyper
approved these changes
Jan 16, 2024
Comment on lines
-88
to
+92
| const globPaths = globSync(args[0].value, { cwd, dotRelative: true }).sort() | ||
| const globPaths = globSync(args[0].value, { cwd, dotRelative: true }) | ||
| .sort() | ||
| .map((globPath) => globPath.replace(/\\/g, '/')) |
There was a problem hiding this comment.
thoughts (non-blocking): at what point should we extract a function for this to ensure this and the above stay in sync?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 129 131 +2
Branches 49 49
=========================================
+ Hits 129 131 +2 ☔ View full report in Codecov by Sentry. |
|
🎉 This PR is included in version 1.1.3 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
globSync()returns a list of file paths. These are passed on torequire()which expects them to be module paths. Under unix file and module paths are the same, under windows filepaths contain\while module paths must have/.Passing a file path under windows then results in a
Cannot find module '.\dir\foo.js'error.Why:
Be compatible with windows dev environments.
How:
All
\are replaced with/Checklist: