Add support for Wacom Cintiq 12WX (DTZ-1200W) 5th and 10th buttons #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbt365
force-pushed
the
cintiq12wx-buttons
branch
from
e2a29a5
to
ed3286f
Compare
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3222.
Data recordings and anything relevant in within that issue.
A new parser is required to keep ordering of the old buttons, maybe a better way exists so that I don't have to duplicate the whole parser.
The way Intuos3 Aux works typically is 4 buttons per side and the byte that the data is different per side, this is why a new parser is needed to not break existing aux.
Alternatively a parser change could be made without creating a new parser but this would mean that the 5th and 10th buttons are the last to be bound instead of them being bound in order, this is not very intuitive and we consider aux buttons not in order to be a quirk. See the TABLETS.md on parblo tablets for example.