Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk configuration merge #3314

Open
wants to merge 71 commits into
base: master
Choose a base branch
from

Conversation

SeaItSelf and others added 30 commits January 25, 2023 18:46
added support for the viewsonic woodpad 10

added to the tablets.md too
update to woodpad 10 config
Information collected from OpenTabletDriver#3183.
This seems like a rebrand of the HS64 under a different name, but the
name is obscure and hard to find any information about, any information
about it just links back to the HS64, hence modifying the original
configuration.
Also move the remaining UGEE tablets from UGTABLET, these don't belong
here.
@InfinityGhost InfinityGhost added the configuration Adds or modifies a tablet configuration label May 11, 2024
@InfinityGhost InfinityGhost added this to the v0.7.0 milestone May 11, 2024
Copy link
Member

@jamesbt365 jamesbt365 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evidence for all tablets supported here seems to be present. Don't see anything immediately off and the linting passes.

I believe the parser change is fine? It works with the users tablet but I haven't see enough of the XP-Pen reports to ensure that this doesn't conflict with other tablets.

@InfinityGhost InfinityGhost marked this pull request as ready for review May 17, 2024 03:23
@InfinityGhost InfinityGhost force-pushed the configs-merge branch 2 times, most recently from 4ff0995 to bda659c Compare May 17, 2024 04:26
Copy link
Member

@X9VoiD X9VoiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed some changes on their respective PRs. If anything changes, we can just merge or cherry-pick them on top of this branch.

Other than those that I have made comments on, everything else is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Adds or modifies a tablet configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet