Veikk A50 revisit #3262
Open
Veikk A50 revisit #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…just 4 aux buttons in a trenchcoat. Renamed V2 report to V1 because no V2 tablets use this parser and it appears to be an older protocol considering the lack of tilt support.
Spencer-Sawyer
force-pushed
the
Veikk-A50-revisit
branch
from
e11038b
to
ee59885
Compare
X9VoiD
reviewed
May 19, 2024
OpenTabletDriver.Configurations/Parsers/Veikk/VeikkAuxV1Report.cs
Outdated
Show resolved
Hide resolved
X9VoiD
reviewed
May 19, 2024
OpenTabletDriver.Configurations/Parsers/Veikk/VeikkV1ReportParser.cs
Outdated
Show resolved
Hide resolved
Reverted Change to VeikkV1ReportParser at Void's suggestion.
X9VoiD
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for aux buttons to one of the existing Veikk parsers and shifted the A50 to use it instead.
Also corrected a confusing naming convention. The V2 parser wasn't actually being used for any V2 tablets. I relabel it V1 because I think it's an older protocol.
I suspect that the other "skip byte tablets" that remain can also be migrated to this parser, but I don't want to touch them without confirmation that it would work correctly.