Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add known issue about parcel to readme #282

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

milafrerichs
Copy link
Contributor

@milafrerichs milafrerichs commented Mar 17, 2021

Description

Documenting an Known issue with parcel.
I ran into this a couple of times already.
reference here: parcel-bundler/parcel#2957

Related Issue

How to test it locally

N/A

Screenshots

N/A

Changelog

Added

Updated

  • updated readme added Known Issues section

Removed

Checklist

  • πŸš€ is the code ready to be merged and go live?
  • πŸ›  does it work (build) locally
  • πŸ‘©β€πŸŽ¨ does the design matches the Demo

Pull Request

  • πŸ“° good title
  • πŸ“good description
  • πŸ”– issue linked
  • πŸ“– changelog filled out
  • commit messages are meaningful

Code Quality

  • 🚧 no commented out code
  • πŸ–¨ no unnecessary logging
  • 🎱 no magic numbers

Testing

  • βœ… added (appropriate) unit tests
  • πŸ’’ edge cases in tests were considered
  • βœ… ran tests locally & are passing

I ran into this a couple of times already.
reference here: parcel-bundler/parcel#2957
@milafrerichs milafrerichs changed the title add known issue about parcel add known issue about parcel to readme Mar 17, 2021
@netlify
Copy link

netlify bot commented Mar 17, 2021

Deploy preview for wazimap-staging ready!

Built with commit 9bb8857

https://deploy-preview-282--wazimap-staging.netlify.app

@milafrerichs milafrerichs merged commit 3810b53 into staging Apr 9, 2021
@adieyal adieyal deleted the chore/readme-known-issues branch June 12, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant