Use functionDelegateCall from the Address library, in conjuction with allow-recheable delegatecall
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
changed the title
functionDelegateCall from the Address library, in conjuction with allow-recheable delegatecall
|
Once this is merged into patches, patches should be merged into patched/master to fix any conflicts |
|
Some things are missing in this PR. For example: You can see the full comparison here: 397c946...patches |
|
Superceded by OpenZeppelin/openzeppelin-contracts#4041. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the upgrade plugins is more precise in its checks, the vanilla contracts are to better target which operations are safe.
See: OpenZeppelin/openzeppelin-contracts#3971
Consequently, the upgradeable contracts can use the Address library again, and don't need to inline their own private version of
functionDelegateCallPR Checklist