Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor SafeMath to avoid memory leaks #2462

Merged
merged 16 commits into from
Jan 18, 2021
Merged

Refactor SafeMath to avoid memory leaks #2462

merged 16 commits into from
Jan 18, 2021

Commits on Jan 8, 2021

  1. Refactor SafeMath to avoid memory leaks 

    FIxes OpenZeppelin#2413, remove the string allocation in SafeMath  default functions: caused unrecovered memory allocation even for successfull calls
    @Amxx
    Amxx committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    5ec2e2d View commit details
    Browse the repository at this point in the history

  2. silence inline assembly warning in mock

    @Amxx
    Amxx committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    9c789b0 View commit details
    Browse the repository at this point in the history

  3. improved coverage

    @Amxx
    Amxx committed Jan 8, 2021
    Configuration menu
    Copy the full SHA
    42e6cfa View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2021

  1. using flags to handle safemath

    @Amxx
    Amxx committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    28ae57f View commit details
    Browse the repository at this point in the history

  2. reduce gas usage by avoiding double if

    @Amxx
    Amxx committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    39bd25d View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. addX renamed to tryAdd

    @Amxx
    Amxx committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    23b65b2 View commit details
    Browse the repository at this point in the history

  2. addressing the memory leak issue in EnumerableMap

    @Amxx
    Amxx committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    2b69162 View commit details
    Browse the repository at this point in the history

  3. test lint + Changelog entry

    @Amxx
    Amxx committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    b75705e View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG.md 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    ce3a5c5 View commit details
    Browse the repository at this point in the history

  5. Update CHANGELOG.md 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    796e7b0 View commit details
    Browse the repository at this point in the history

  6. Update contracts/math/SafeMath.sol 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    f09506b View commit details
    Browse the repository at this point in the history

  7. Update contracts/math/SafeMath.sol 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    241f5d5 View commit details
    Browse the repository at this point in the history

  8. Update contracts/math/SafeMath.sol 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    05e6618 View commit details
    Browse the repository at this point in the history

  9. Update contracts/math/SafeMath.sol 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    d39f5d4 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. notices + addressing comment about testign helper

    @Amxx
    Amxx committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    80466e3 View commit details
    Browse the repository at this point in the history

  2. fix lint

    @Amxx
    Amxx committed Jan 16, 2021
    Configuration menu
    Copy the full SHA
    28b4b53 View commit details
    Browse the repository at this point in the history