Add ERC721Votes for NFT-based governance #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Nov 4, 2021
|
Note regarding next steps: There are some challenges around implementing |
|
I implemented erc721 voting with different weights and delegation. Since I was working with a diamond I moved the whole logic into a library, though the function names are the same as in the oz implementation. Maybe this helps as well.. Note: I did not compare the implementation on this pr with my own so I might have missed something. I will check that in the next days. |
|
We will resume this PR next week. |
JulissaDantes
changed the title
* Add function to handle mint and burn before moving voting power * Update README.adoc * rename files to new names * Rename function getTotalSupply * Change test function name * Fix documentation after function rename * improve documentation * Update Votes.sol documentation * Add Chekpoints.sol documentation * Improve ERc721 documentation Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
frangio
reviewed
Dec 6, 2021
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
…penzeppelin-contracts into ERC721Governance Pull latest change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2873
Governance with NFT-backed votes. An ERC721Votes extension of ERC721 and a GovernorVotesERC721 module for OZ Governor contract. The contracts is be analogous to ERC20Votes and GovernorVotes, but for NFTs.
PR Checklist
Suggested Next steps
So far this implementation account for 1 Token = 1 vote, if a
_getVotingPowerinternal virtual function is created, taking the token Id and returning the voting power of such token, that would allow for differently weighted token(you could call it token rarity or token value) to be used as voting power.