Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused using statements in GovernorCompatibilityBravo #3506

Merged
merged 1 commit into from
Jun 27, 2022

Commits on Jun 24, 2022

  1. Update GovernorCompatibilityBravo.sol

    GovernorCompatibilityBravo.sol contains two `using` statements which are not used inside that contract.
    
    ```javascript
    using Counters for Counters.Counter;
    using Timers for Timers.BlockNumber;
    ```
    
    [Since Solidity 0.7.0](https://docs.soliditylang.org/en/latest/070-breaking-changes.html#functions-and-events), `using` statements no longer affect downstream contracts in inheritance hierarchy.
    
    > `using A for B` only affects the contract it is mentioned in. Previously, the effect was inherited. Now, you have to repeat the `using` statement in all derived contracts that make use of the feature.
    
    Since these statements are not used inside this contract, and cannot affect anything upstream or downstream of them inheritance, they should be safe to remove.
    DanielVF committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    ea90cd6 View commit details
    Browse the repository at this point in the history