Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AccessControlDefaultAdminRules #4009

Merged
merged 78 commits into from
Feb 24, 2023
Merged

Add AccessControlDefaultAdminRules #4009

merged 78 commits into from
Feb 24, 2023

Commits on Jan 27, 2023

  1. Create AccessControlAdminRules and its corresponding interface

    @ernestognw
    ernestognw committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    3989054 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Add tests

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    da52678 View commit details
    Browse the repository at this point in the history

  2. Add changeset

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    f7738a6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    e2eb45d View commit details
    Browse the repository at this point in the history

  4. Correctly set unlocked crite

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    68adaf5 View commit details
    Browse the repository at this point in the history

  5. Completed docs

    @ernestognw
    ernestognw committed Jan 28, 2023
    2 Configuration menu
    Copy the full SHA
    0aff3ff View commit details
    Browse the repository at this point in the history

  6. Fix linter

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    4090a3e View commit details
    Browse the repository at this point in the history

  7. Refactor tests so coverage is not reduced

    @ernestognw
    ernestognw committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    21aacf9 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Address PR review comments

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2863047 View commit details
    Browse the repository at this point in the history

  2. Update contracts/access/AccessControlAdminRules.sol 

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    @ernestognw @Amxx
    ernestognw and Amxx committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    a9a3495 View commit details
    Browse the repository at this point in the history

  3. Add draft-ERC5313

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    59f3b62 View commit details
    Browse the repository at this point in the history

  4. Remove property-based test

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2bfb028 View commit details
    Browse the repository at this point in the history

  5. Fix typo

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7ae4aa7 View commit details
    Browse the repository at this point in the history

  6. Add IERC5313 docs

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    2d630c3 View commit details
    Browse the repository at this point in the history

  7. Change owner for admin

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    192c5bc View commit details
    Browse the repository at this point in the history

  8. Call overrideable functions

    @ernestognw
    ernestognw committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    021ee37 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Update IERC5313 to final

    @ernestognw
    ernestognw committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    a54dd2b View commit details
    Browse the repository at this point in the history

  2. Reword private function

    @ernestognw
    ernestognw committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    85cff36 View commit details
    Browse the repository at this point in the history

  3. Remove property test again

    @ernestognw
    ernestognw committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8baa13b View commit details
    Browse the repository at this point in the history

  4. Rename again

    @ernestognw
    ernestognw committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    fb895d2 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 4, 2023
    Configuration menu
    Copy the full SHA
    3fbfbac View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    b70ae34 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Update .changeset/silent-dancers-type.md 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d120c1d View commit details
    Browse the repository at this point in the history

  2. Update contracts/access/AccessControl.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    4322ed7 View commit details
    Browse the repository at this point in the history

  3. Update docs/modules/ROOT/pages/access-control.adoc 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d52b371 View commit details
    Browse the repository at this point in the history

  4. Rename to defaultAdmin

    @ernestognw
    ernestognw committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    54184af View commit details
    Browse the repository at this point in the history

  5. Update contracts/access/AccessControlAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d1064f4 View commit details
    Browse the repository at this point in the history

  6. Update contracts/access/AccessControlAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    d352694 View commit details
    Browse the repository at this point in the history

  7. Rename delayedUntil

    @ernestognw
    ernestognw committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    53e8087 View commit details
    Browse the repository at this point in the history

  8. Lint

    @ernestognw
    ernestognw committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    56b5df6 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    30306c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Small fixes

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    701d341 View commit details
    Browse the repository at this point in the history

  2. More typos and minor corrections

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8ebb27b View commit details
    Browse the repository at this point in the history

  3. Allow defaultAdmin to start transfer again

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    f7c6596 View commit details
    Browse the repository at this point in the history

  4. Add extra test

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    5092d70 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    4642a12 View commit details
    Browse the repository at this point in the history

  6. Rename to AccessControlDefaultAdminRules

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    630df0d View commit details
    Browse the repository at this point in the history

  7. Removed IAccessControlDefaultAdminRules

    @ernestognw
    ernestognw committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    07d12a2 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Add note in Extending Contracts section

    @ernestognw
    ernestognw committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    41f4ba3 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
    @ernestognw @Amxx
    ernestognw and Amxx committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    6da27ad View commit details
    Browse the repository at this point in the history

  2. Fix comments example

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    4b39c30 View commit details
    Browse the repository at this point in the history

  3. Add virtual to delay()

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    da8227f View commit details
    Browse the repository at this point in the history

  4. Replace _delay with getter

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    6139905 View commit details
    Browse the repository at this point in the history

  5. Add IAccessControlDefaultAdmin back

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    f420162 View commit details
    Browse the repository at this point in the history

  6. Created interal functions for beginning and accepting transfers

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    8747bf4 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    444908c View commit details
    Browse the repository at this point in the history

  8. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    5743d7a View commit details
    Browse the repository at this point in the history

  9. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    0b9ea0b View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Fixed test error message

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    780e901 View commit details
    Browse the repository at this point in the history

  2. Change delay to defaultAdminDelay

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    24ce7fa View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    a8bbf18 View commit details
    Browse the repository at this point in the history

  4. Change long variable name

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2c4e15e View commit details
    Browse the repository at this point in the history

  5. Run prettier

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d171299 View commit details
    Browse the repository at this point in the history

  6. Remove IAccessControlDefaultAdminRules from docs

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    281209c View commit details
    Browse the repository at this point in the history

  7. Remove camel case from error messages

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2c49a5d View commit details
    Browse the repository at this point in the history

  8. Update test/access/AccessControl.behavior.js 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    cb98ad9 View commit details
    Browse the repository at this point in the history

  9. Update test/access/AccessControl.behavior.js 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    88168be View commit details
    Browse the repository at this point in the history

  10. Use beforeEach in begin transfer tests

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    39d176a View commit details
    Browse the repository at this point in the history

  11. Update test/access/AccessControl.behavior.js 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9e52530 View commit details
    Browse the repository at this point in the history

  12. Update test/access/AccessControl.behavior.js 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4721d63 View commit details
    Browse the repository at this point in the history

  13. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    0e532c7 View commit details
    Browse the repository at this point in the history

  14. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    70c5cae View commit details
    Browse the repository at this point in the history

  15. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    667e3da View commit details
    Browse the repository at this point in the history

  16. Remove unnecessary async

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    5a31431 View commit details
    Browse the repository at this point in the history

  17. Change is met for has passed

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    14994be View commit details
    Browse the repository at this point in the history

  18. Change note in docs

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fd64f5d View commit details
    Browse the repository at this point in the history

  19. Update contracts/access/AccessControlDefaultAdminRules.sol 

    Co-authored-by: Francisco <fg@frang.io>
    @ernestognw @frangio
    ernestognw and frangio committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    9e04336 View commit details
    Browse the repository at this point in the history

  20. Simplify renouncing tests

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ac093f4 View commit details
    Browse the repository at this point in the history

  21. Extend cancel tests

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3948246 View commit details
    Browse the repository at this point in the history

  22. Rename delay test variables

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    34ed74f View commit details
    Browse the repository at this point in the history

  23. Remove confusing comment

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    880ac0b View commit details
    Browse the repository at this point in the history

  24. Replace met with passed

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3337f61 View commit details
    Browse the repository at this point in the history

  25. Simplified acceptance tests

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    a43abe7 View commit details
    Browse the repository at this point in the history

  26. Add IAccessControlEnumerable interface removed accidentally from docs

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b4ee08a View commit details
    Browse the repository at this point in the history

  27. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @ernestognw
    ernestognw committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b2b9e81 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. Merge branch 'master' into lib-618-accesscontrol-admin-rules

    @frangio
    frangio committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    d1289a2 View commit details
    Browse the repository at this point in the history

  2. fix flaky tests

    @frangio
    frangio committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    7d37c81 View commit details
    Browse the repository at this point in the history

  3. lint

    @frangio
    frangio committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    b164929 View commit details
    Browse the repository at this point in the history