Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ERC4626 event coverage #4072

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Improve ERC4626 event coverage #4072

merged 1 commit into from
Feb 23, 2023

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 23, 2023

Fixes #3979 (comment)

PR Checklist

  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

⚠️ No Changeset found

Latest commit: b6523d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Amxx Amxx requested a review from frangio February 23, 2023 18:27
@Amxx Amxx mentioned this pull request Feb 23, 2023
Merged
3 tasks
frangio
frangio approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frangio frangio merged commit a6b8366 into OpenZeppelin:master Feb 23, 2023
@Amxx Amxx deleted the tests/erc4626/more branch February 27, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
ignore-changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amxx @frangio