Remove hardhat-foundry and check harnesses compilation in CI

[ernestognw]

Before merging #4781, I tried running the FV in master and it resulted in a compilation error after 25c416d

I fixed the issues and renamed variables accordingly. I'm also adding a check for it in the CI to avoid happening again.

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: d8e5046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Amxx]

any reason for this rollback ? IMO, if the coverage is enabled, then optimizations should be on, but contract size should not be limitted. (coverage does increasse the size)

[Amxx]

I first wanted to use conflicts, but then decided against it because it caused issues with SRC.

I review you proposal, but it doesn't work. If I do FOUNDRY=true yarn test or even FOUNDRY=false yarn test, then both foundry and src are defined (first one is a boolean, second one is a string) ... which causes conflict to fail:

Les arguments foundry et src sont mutuellement exclusifs

as nice as yargs's "conflict" is, it doesn't work for us because the conflict is not in the options being defined (what conflict checks) but in the options being turned on or modified from the default value.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@nomicfoundation/hardhat-foundry@1.1.1

View full report↗︎

[Amxx]

It appears that both checks/tests, and checks/tests-foundry work without the foundry hardhat package.

The package still has a usage though: it overrides the TASK_COMPILE_GET_REMAPPINGS hardhat task so the remappings.txt file is considered. This is used by the upgradeable tests.

I'm proposing we remove the hardhat-foundry, because of the complexity is adds to handling configs in hardhat.config.js ... and add a dedicated script in the hardhat folder to maintain the remappings.txt support.

[ernestognw]

It appears that both checks/tests, and checks/tests-foundry work without the foundry hardhat package.

The package still has a usage though: it overrides the TASK_COMPILE_GET_REMAPPINGS hardhat task so the remappings.txt file is considered. This is used by the upgradeable tests.

I'm proposing we remove the hardhat-foundry, because of the complexity is adds to handling configs in hardhat.config.js ... and add a dedicated script in the hardhat folder to maintain the remappings.txt support.

After reviewing it looks good. The downside of this is that remappings are inherited from other submodules and also include some defaults. Now we shouldn't have access to those but aren't required. In any case, we can always:

• Read remappings from forge remappings conditionally if forge is available
• Adapt our remappings.txt

LGTM