fix(app): remove copy link from context menu

[koji]

Overview

This will fix #10054
Removed copy link by using the menu function
https://github.com/sindresorhus/electron-context-menu#menu.

There is a kind of issue with electron-context-menu in this project.

The version app-shell uses is 0.15.0 (released in Aug 2019). The current version is 3.1.2.
For safe, I would like to upgrade this package by another PR.

In addition, 0.15.0 has an issue with searchWithGoogle option.

Changelog

• Updated contextMenu option

Review requests

no copy link

Risk assessment

low

[codecov]

Codecov Report

Merging #10328 (98350d3) into edge (fb4ed1f) will increase coverage by 0.40%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             edge   #10328      +/-   ##
==========================================
+ Coverage   73.97%   74.37%   +0.40%     
==========================================
  Files        2133     2129       -4     
  Lines       56900    56510     -390     
  Branches     5753     5807      +54     
==========================================
- Hits        42090    42031      -59     
+ Misses      13608    13262     -346     
- Partials     1202     1217      +15     

Flag	Coverage Δ
app	71.11% <0.00%> (-0.16%)	⬇️
ot3-gravimetric-test	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
app-shell/src/main.ts	0.00% <0.00%> (ø)
app/src/atoms/Slideout/index.tsx	66.66% <0.00%> (-8.34%)	⬇️
...rganisms/ProtocolsLanding/ProtocolOverflowMenu.tsx	81.57% <0.00%> (-8.08%)	⬇️
app/src/organisms/ProtocolDetails/index.tsx	41.02% <0.00%> (-5.65%)	⬇️
...e/hardware_control/motion_planning/move_manager.py	89.36% <0.00%> (-4.26%)	⬇️
...pp/src/organisms/Devices/HistoricalProtocolRun.tsx	45.00% <0.00%> (-2.37%)	⬇️
...are/hardware_control/motion_planning/move_utils.py	89.83% <0.00%> (-1.61%)	⬇️
...ware/opentrons_hardware/hardware_control/motion.py	90.90% <0.00%> (-1.25%)	⬇️
app-shell/src/config/migrate.ts	89.28% <0.00%> (-0.72%)	⬇️
...Devices/RobotSettings/RobotSettingsCalibration.tsx	67.15% <0.00%> (-0.04%)	⬇️
... and 21 more

[koji]

Passing {} because currently, options are not optional.

sindresorhus/electron-context-menu#153

Once fix the above issue, probably we can remove {}

[vabruzzo]

Perhaps a TODO with that link would be useful for tracking this?

[ecormany]

Looks good in the GUI. I see we decided to keep "Look up…" for compatibility, and it works. No "Copy Link" anywhere.

[koji]

Looks good in the GUI. I see we decided to keep "Look up…" for compatibility, and it works. No "Copy Link" anywhere.

@ecormany I keep Look up since the version the app uses is very old (0.1.5 the latest version is 3.1.2 😹) and there is an issue with adding searchWithGoogle as an option. In my opinion, upgrading a package is kind of troublesome. I would like to open another PR for adding searchWithGoogle which is including upgrading the package.

[ecormany]

the version the app uses is very old (0.1.5 the latest version is 3.1.2 😹)

glad we pin our dependencies 🤣