test(protocol-designer, labware-library): update cypress #14971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
force-pushed
the
chore_update-cypress
branch
from
7bc6302
to
43d9985
Compare
shlokamin
commented
Apr 29, 2024
| @@ -5,7 +5,7 @@ port ?= 6060 | |||
|
|
|||
| # These variables can be overriden when make is invoked to customize the | |||
| # behavior of jest | |||
| tests ?= | |||
| tests ?= src | |||
There was a problem hiding this comment.
i made this change because other tests in /components subdirs were getting picked up (protocol-designer/*/components, app/*/components)
shlokamin
requested review from
koji and
jerader
and removed request for
a team
koji
reviewed
May 3, 2024
|
|
||
| describe('Reservoir', () => { | ||
| before(() => { | ||
| // TODO(IL, 2021-05-15): give Dropdown component semantic selectors for E2E |
There was a problem hiding this comment.
no probably not, ill get rid of it!
koji
approved these changes
May 3, 2024
jerader
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates cypress from 6.6.0 to 13.7.1, and fixes various tests to accommodate the 5 major version bumps.
For reasons I do not understand (praise the Gods of package management) this PR fixes the jsdom issue we were seeing before where styled-components in the testing environment would get rendered with their active styles by default. So, a lot of the file changes here are reverting tests back to what they were prior to the vite migration.
closes AUTH-219 and AUTH-220
Changelog
Review requests
Verify e2e tests pass
Risk assessment
Low