Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Python requirements and simulation behavior in Tutorial #15208

Merged
merged 2 commits into from
May 17, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Some changes to the Tutorial page to reflect the current requirements and capabilities of opentrons_simulate.

Notably, the duration estimator never made it out of beta and is fully broken now, so mentions of it have been removed.

Test Plan

Tutorial in sandbox

Changelog

  • Mention Python 3.10 and pyenv
  • Remove instruction to use opentrons_simulate -e

Risk assessment

none

@ecormany ecormany requested a review from a team as a code owner May 16, 2024 20:43
Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are reasonable. LGTM

I did add a comment about the Python 3.10, recommending we make the language stronger about the required version.

To run your code, make sure that you've installed `Python 3 <https://wiki.python.org/moin/BeginnersGuide/Download>`_ and the `pip package installer <https://pip.pypa.io/en/stable/getting-started/>`_. You should write your code in your favorite plaintext editor or development environment and save it in a file with a ``.py`` extension, like ``dilution-tutorial.py``.
You should write your code in your favorite plaintext editor or development environment and save it in a file with a ``.py`` extension, like ``dilution-tutorial.py``.

To run your code, make sure that you've installed `Python 3.10 <https://www.python.org/downloads/>`_ and the `pip package installer <https://pip.pypa.io/en/stable/getting-started/>`_. If you don't use Python 3.10 as your system Python, we recommend using `pyenv <https://github.com/pyenv/pyenv>`_ to manage multiple Python versions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be stronger, the requirement about Python 3.10?

Instead of, "make sure you've installed it" to something like, "The Opentrons simulation feature only works with Python 3.10" or "To simulate your code, you must use Python 3.10." Something that indicates opentrons_simulate requires this version.

@ecormany ecormany merged commit 23c8eab into edge May 17, 2024
20 checks passed
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
…15208)

# Overview

Some changes to the Tutorial page to reflect the current requirements
and capabilities of `opentrons_simulate`.

Notably, the duration estimator never made it out of beta and is fully
broken now, so mentions of it have been removed.

# Test Plan

[Tutorial in
sandbox](http://sandbox.docs.opentrons.com/docs-simulation-python-updates/v2/tutorial.html)

# Changelog

- Mention Python 3.10 and `pyenv`
- Remove instruction to use `opentrons_simulate -e`

# Risk assessment

none
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
…15208)

# Overview

Some changes to the Tutorial page to reflect the current requirements
and capabilities of `opentrons_simulate`.

Notably, the duration estimator never made it out of beta and is fully
broken now, so mentions of it have been removed.

# Test Plan

[Tutorial in
sandbox](http://sandbox.docs.opentrons.com/docs-simulation-python-updates/v2/tutorial.html)

# Changelog

- Mention Python 3.10 and `pyenv`
- Remove instruction to use `opentrons_simulate -e`

# Risk assessment

none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants